Navigation Block: Avoid creating a new array/object on every render#30374
Merged
Navigation Block: Avoid creating a new array/object on every render#30374
Conversation
Contributor
Author
|
This PR's not strictly necessary now that #30311 is merged, but it is a very minor optimisation. |
|
Size Change: -2 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
Contributor
|
👍 Optimisation + clearer code |
grzim
approved these changes
Mar 30, 2021
ellatrix
reviewed
Mar 30, 2021
Member
ellatrix
left a comment
There was a problem hiding this comment.
It's is good practice to keep this out of component render functions, but we should assume that block authors are not doing this. I wonder if we should leave it as is to better expose problems? I don't mind either way.
Contributor
Author
I was wondering about tests for it. It's easy enough to add a block via a plugin that creates a new array on every render, but not sure how we'd detect the problem, as it doesn't seem like a completely consistent behaviour. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same as #30274, the navigation block is also creating new arrays and objects for inner blocks props on every render.
Types of changes
Task
Checklist:
*.native.jsfiles for terms that need renaming or removal).