Remove obsolete editor styles for List block.#30094
Merged
ZebulanStanphill merged 1 commit intotrunkfrom Mar 23, 2021
Merged
Conversation
This was referenced Mar 22, 2021
|
Size Change: -177 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
Contributor
|
Trying to test this, on the frontend I'm not seeing the style.css of the list being loaded? (Using an emptytheme) Is it just me? In the editor everything is correct. |
Contributor
|
cc @aristath maybe that's related to the lazy loading since I'm using an FSE theme. |
youknowriad
approved these changes
Mar 23, 2021
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
The error was on my install. Sorry about that. This PR is cool.
aristath
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Thanks to #30034, the editor styles introduced in #21387 for the List block can now be removed since the normal block styles in the block's
style.scsswill take precedence as expected.Testing instructions.
Make sure the List block color controls still work in the editor.
Checklist: