Block editor: use proper insertion point for drop#29933
Merged
Conversation
6 tasks
Member
Author
|
For some reason I'm just getting an error in the navigation block when I start dragging. @talldan Any ideas? |
|
Size Change: -128 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
Member
|
Nice! I hope we can also develop some logic to consider empty containers (empty column, empty group, empty paragraph) as more clear drop targets. Instead of using a line it should be closer to #29145 |
talldan
approved these changes
Mar 26, 2021
Contributor
There was a problem hiding this comment.
Sorry for not replying to the earlier ping.
I think it'd be great to get this in.
The appender is also a problem with the current system as it's often conditionally rendered, so I think this has lots of benefits
When testing in nested blocks, I noticed the indicator sometimes flickers. #30272 seems to resolve that, so it'd be great to get that improvement in as well.
1cdad33 to
8e2fa3b
Compare
This was referenced Mar 26, 2021
Member
Author
|
Let's merge and iterate on the unified insertion point! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refresh of #27537. Keeping the other PR as a reference.
How has this been tested?
Screenshots
Types of changes
Checklist: