Skip to content

Cover: Improve disabled media buttons check for placeholder#29858

Merged
jasmussen merged 1 commit intoWordPress:trunkfrom
Mamaduka:fix/cover-has-background-check
Mar 15, 2021
Merged

Cover: Improve disabled media buttons check for placeholder#29858
jasmussen merged 1 commit intoWordPress:trunkfrom
Mamaduka:fix/cover-has-background-check

Conversation

@Mamaduka
Copy link
Copy Markdown
Member

Description

Prevents placeholder from being rendered, when using cover block without media. See #29813.

Thanks, @jasmussen for catching this issue.

How has this been tested?

  1. Add cover block.
  2. Select color.
  3. See if the placeholder is rendered.

Types of changes

Bugfix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@Mamaduka Mamaduka requested a review from ajitbohra as a code owner March 15, 2021 07:26
@jasmussen jasmussen self-requested a review March 15, 2021 08:38
Copy link
Copy Markdown
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautifully small changeset, and works for me. Thank you for fast work 👌

Before:

Screenshot 2021-03-15 at 09 36 07

After:

Screenshot 2021-03-15 at 09 37 47

@getsource
Copy link
Copy Markdown
Member

Tested, and works here with the same results as well. Thanks!

Copy link
Copy Markdown
Member

@ajitbohra ajitbohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants