Update block design principles with a new section on how to group controls#29816
Merged
Update block design principles with a new section on how to group controls#29816
Conversation
…trols This takes a first stab at creating new documentation for block toolbar group best practices. See also #25983.
aristath
approved these changes
Mar 12, 2021
Contributor
Author
|
💯 So fast! Thank you Ari! |
Member
|
Awesome, this is a great example of what we need to codify more, thanks! |
mtias
reviewed
Mar 12, 2021
|
|
||
| ### Group Block Toolbar controls with related items | ||
|
|
||
| The Block Toolbar groups controls in segments, hierarchically. The first segment contains block controls, such as the block switcher, the drag handle, and the mover control. The second group commonly contains tools, followed by inline formatting, and the "More" menu. Optionally "Meta" or "Other" groups can separate some tools in their own segment. |
Member
There was a problem hiding this comment.
Some suggestions:
The first segment contains block type controls, such as the block switcher, the drag handle, and the mover control. The second group contains common and specific block tools that affect the entire block, followed by inline...
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
mtias
approved these changes
Mar 12, 2021
Member
|
Could we link each of the hierarchy names (Block, Tools, Meta, etc.) to the exact values that one should pass to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This takes a first stab at creating new documentation for block toolbar group best practices.
See also #25983.
Screenshots
There's also a new "Do and don't" section for the block toolbar:
I also updated the placeholder screenshot while I was there:
The rest of the screenshots also need updating, but one step at a time.