Rename load_separate_block_styles to load_separate_block_assets#29703
Merged
Rename load_separate_block_styles to load_separate_block_assets#29703
Conversation
7 tasks
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Mar 10, 2021
Member
gziolo
left a comment
There was a problem hiding this comment.
Thank you for a quick fix 👍🏻
Do you think it needs some proxy with deprecation in case someone was using the filter?
Member
Author
I don't think so... This was part of FSE so by definition experimental 😄 |
Member
|
Yes, let's merge as is 👍🏻 |
Member
Author
|
The failing test is not related to this PR so I'll go ahead and merge it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR renames a filter and a function from _styles
to_assets`. These will be used for scripts as well, so their name needs to be less specific and cover both cases.load_separate_block_stylesfilter toload_separate_block_assetsgutenberg_should_load_separate_block_stylesfunction togutenberg_should_load_separate_block_assetsChecklist: