Components: Add Tooltip and Shortcut#29385
Merged
sarayourfriend merged 8 commits intotrunkfrom Mar 2, 2021
Merged
Conversation
sarayourfriend
commented
Feb 26, 2021
|
Size Change: +2.66 kB (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
32 tasks
1b5307c to
87fa686
Compare
|
@sarayourfriend I guess we don't need |
ItsJonQ
approved these changes
Mar 2, 2021
ItsJonQ
left a comment
There was a problem hiding this comment.
🚀 from me! Thanks @sarayourfriend ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new Tooltip component as well as a new Shortcut component that was necessary to successfully adapt the current Tooltip to the new one.
Note: I added
Shortcutin TypeScript (🎉) Hopefully this is okay! If not, I can convert it to regular JS pretty easily anyway, but I think it'd be cool if we can start taking advantage of native TS support 🙂How has this been tested?
Storybook and unit tests
Screenshots
Types of changes
New features
Checklist: