Add new overlay text icon, and use for image#29215
Merged
Conversation
Contributor
Author
|
Please note I had to commit using --no-verify because of an update-api-docs.js failure that appeared unrelated. But wanted to just share in case it wasn't. |
|
Size Change: +1.13 kB (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
gwwar
approved these changes
Feb 23, 2021
Contributor
gwwar
left a comment
There was a problem hiding this comment.
Icon changes look good ✨
| Storybook | Image |
|---|---|
 |
 |
Contributor
Author
|
Thanks for the green light Kerry! I actually got some feedback suggesting a lowercase a might better ambiguate from text color:
So I took the liberty of pushing that. I'll let this one sit for a moment, and then merge later today unless objections land! |
Contributor
Author
|
Landing this one, and always happy to revisit! |
Contributor
|
Just a quick note that I keep seeing this and think its a broken font, like the missing @ sign in the screenshot: |
Contributor
Author
|
Good thing we went lowercase the 😅 I think the new icon is a big upgrade over what was there before, and that it's worth trying this out for a plugin version, see how it feels. If it still feels like a missing glyph in a week or two, I'll come back to this one. What do you say? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a new overlay text icon, and uses it in the image block for the conversion to cover.
How has this been tested?
Test converting an image to a cover using the toolbar button.
Screenshots
Before:
After:
Checklist: