Conversation
|
Size Change: -2 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
aristath
approved these changes
Feb 22, 2021
Member
aristath
left a comment
There was a problem hiding this comment.
I honestly don't see a difference, but everything looks OK to me here so I'm good with this 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "text color" icon is an older smaller icon:
This PR updates it:
Yes, the difference is barely perceptible, but the new version is slightly better balanced, centered, and is based on the same font that the Bold and Italic icons are based on.
Why isn't it larger, you ask? Because it has to be balanced for the colored bar below when used for text color:
There's a separate conversation to be had on whether we might want to explore a larger A for the Cover block transform action. Happy to follow up.
How has this been tested?
Test inserting an Image and observing the A icon. Test setting inline text color in a paragraph.
Checklist: