Iframe, selection clearer, typing observer: use ref callbacks#29114
Merged
Iframe, selection clearer, typing observer: use ref callbacks#29114
Conversation
ellatrix
commented
Feb 18, 2021
| contentRef={ contentRef } | ||
| contentRef={ mergedRefs } | ||
| > | ||
| <Canvas body={ contentRef } /> |
Member
Author
There was a problem hiding this comment.
Notice how we no longer need a separate component, because the hook can be called before the content is mounted.
|
Size Change: -17 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
Contributor
|
@ellatrix The navigation editor also uses |
7 tasks
Member
Author
|
Apologies @talldan. I did check the other hooks but forgot one. No tests were failing, so it slipped through. The changes in the PR are otherwise chore-like and unsurprising. Mistakes happen sometimes and they can easily be rectified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
Screenshots
Types of changes
Checklist: