Closed
Conversation
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
Member
|
👋 I have two thoughts about this:
|
Member
Author
Correct
The problem is that core doesn't have a method to load fonts... As a result plugins & themes are forced to deal with it anyway and re-invent the wheel every time. There have been proposals to add an API to allow loading webfonts with a consistent method, but that's a big project on its own and will probably take a long time before something can land in core. |
a866186 to
3fc9a53
Compare
Member
Author
|
Rebased the PR and fixed a conflict, this is now again ready for a review. |
Member
|
In #34843 I'm asking people for thoughts about consolidating parts of the global styles API, particularly the API for themes & plugins to get access to the data from |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While working on an FSE theme and trying to figure out how to load webfonts, it became apparent that there is currently no way for a theme to determine if a webfont defined in the
theme.jsonfile is actually used. As a result, themes are forced to always load webfonts they want to use.This PR adds a
global_stylesfilter to allow 3rd-party developers (both in themes and plugins) to filter the global styles on the frontend in order to add things if needed.Example for the webfont:
Types of changes
gutenberg_experimental_global_styles_get_stylesheetfunction's return.Checklist: