[RNMobile] Disable Unsupported block editor for Reusable blocks#28552
Merged
[RNMobile] Disable Unsupported block editor for Reusable blocks#28552
Conversation
|
Size Change: +37 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
2 tasks
guarani
reviewed
Jan 28, 2021
Contributor
guarani
left a comment
There was a problem hiding this comment.
Reviewed via wordpress-mobile/gutenberg-mobile#3067 (review)
| import styles from './style.scss'; | ||
|
|
||
| // Blocks that can't be edited through the Unsupported block editor identified by their name. | ||
| const UBE_UNSUPPORTED_BLOCKS = [ 'core/block' ]; |
Contributor
There was a problem hiding this comment.
Would "INCOMPATIBLE" work better than "UNSUPPORTED" here? Given that UBE stands for Unsupported Block Editor, I think using the word unsupported here could lead to confusion. I'd find it easier to think that the reusable block is incompatible with the Unsupported Block Editor, than to think that it is unsupported by the Unsupported Block Editor.
Edit: It is kind of humorous that there are blocks which not even the Unsupported Block Editor can edit 😅 .
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
PS: If a block is not supported by the Unsupported block editor, wouldn't that mean that is a supported block? 🤣
🤣
5d3e1de to
08854a4
Compare
guarani
approved these changes
Jan 29, 2021
Contributor
guarani
left a comment
There was a problem hiding this comment.
Tested via wordpress-mobile/gutenberg-mobile#3067 (review).
LGTM!
Contributor
Author
|
I've tried to re-run the PR checks multiple times but they keep failing, I don't think they're failing due to these PR changes but I'm concerned about merging it with some checks in red. However I saw that most of the recent merged PRs had the same issue so maybe it's safe to merge it 🤔 . |
Contributor
Author
On |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3067Description
Reusable blocks are no longer editable through UBE (Unsupported block editor) due to recent changes in the editing flow on the web version. Until we fully support editing them in the native editor, the edition through UBE should be disabled.
core/block[Reusable block] (only enabled in development mode)All UBE related logic has been removed, now on double tap on the block only a message is displayed.
missing/block[Missing block]A list with the unsupported blocks has been added to this block, this way we can control whether display the option for editing it using the web editor (UBE).
How has this been tested?
Since these changes are related to unsupported blocks, it requires a quick setup to be done in the web version editor:
jetpack/gif).The following flows have been used for testing these changes:
Reusable block (dev mode only)
This has to be tested in development mode.
Steps
Missing block - UBE supported block
Steps
Missing block - UBE unsupported block
This has to be tested in release mode or by disabling the Reusable block from the block list in
block-librarypackage.Steps
Screenshots
Reusable block (dev mode only)
Missing block (jetpack/gif) - UBE supported block
Missing block (core/block) - UBE unsupported block
Types of changes
Checklist: