[RNMobile] Refactor blockWidth setting and passing down#28489
Merged
cameronvoell merged 4 commits intomasterfrom Jan 27, 2021
Merged
[RNMobile] Refactor blockWidth setting and passing down#28489cameronvoell merged 4 commits intomasterfrom
cameronvoell merged 4 commits intomasterfrom
Conversation
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
2 tasks
geriux
approved these changes
Jan 27, 2021
Member
geriux
left a comment
There was a problem hiding this comment.
LGTM! Tested it on an iPhone, iPad (with split-view), and Android.
Nice work Luke!
dratwas
approved these changes
Jan 27, 2021
Contributor
dratwas
left a comment
There was a problem hiding this comment.
Everything seems fine ;) I have one small idea, WDYT about passing the blockWidth through context? It's a primitive variable so there will not be an issue with a new references etc.
Member
|
Tests all green after CI restart. I see it's approved so I'll go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
That PR is extending the merged part and fixes and improves the logic for setting and passind down by props the block width.
Ref to gb-mobile: wordpress-mobile/gutenberg-mobile#3052
How has this been tested?
Coverblock and choose the colorExpect the paragraph block is visible and editable
ButtonsblockExpect two buttons are visible and editable
GroupblockExpect nested block is displayed properly
SocialLinksblockExpect block is displayed properly
Media&TextblockExpect block is displayed properly
ColumnsblockColumnsExpect block along with nested blocks is displayed properly
Expect blocks extends properly
Screenshots
Types of changes
Bug fix - fixes the issue with undefined block width within inner blocks.
Checklist: