Fix repeated backgrounds with transparent images#28362
Merged
ajlende merged 1 commit intoWordPress:masterfrom Jan 22, 2021
Merged
Fix repeated backgrounds with transparent images#28362ajlende merged 1 commit intoWordPress:masterfrom
ajlende merged 1 commit intoWordPress:masterfrom
Conversation
2a42e0c to
65f7c9c
Compare
6 tasks
65f7c9c to
fdef2cb
Compare
mkaz
approved these changes
Jan 21, 2021
Member
mkaz
left a comment
There was a problem hiding this comment.
I didn't test previously with an image that had transparency, so missed this previous.
It looks fine now, tested with small transparent image and don't notice the same.
aristath
approved these changes
Jan 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #28310 (comment)
cover-srcset-repeated.mp4
In re-enabling the image repeat feature, I missed removing the
<img>element when it was enabled. This removes that<img>element when the repeat feature is enabled. Thanks again to @stokesman!How has this been tested?
Easiest to see with an image using transparency or a small image, enable the repeat feature and see that there isn't an overlapping image with the background.
Screenshots
Types of changes
Bug fix.
Checklist: