Merged
Conversation
6 tasks
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Jan 19, 2021
Member
Author
|
Going to merge as it is, we can always do the other approach later if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up.
The support for the border-radius property in the root element doesn't work because it's declared as
borderwhile it should have been declared asborderRadius. The values on theGLOBAL_SUPPORTSarray need to be the same as the property names in thePROPERTIES_METADATA.There are two potential fixes here:
:rootselector so I'm not sure it makes much sense to have this property. There's also the issue that there's no UI control for users to tweak this property via the global styles sidebar.bordertoborderRadius.I've opted for going with 1, but if we want to go with 2 we just need to revert the last commit 12ea434