[RNMobile] Performance- refactor setting blockWidth in block list item#28299
Merged
lukewalczak merged 3 commits intomasterfrom Jan 25, 2021
Merged
[RNMobile] Performance- refactor setting blockWidth in block list item#28299lukewalczak merged 3 commits intomasterfrom
lukewalczak merged 3 commits intomasterfrom
Conversation
|
Size Change: +104 kB (+8%) 🔍 Total Size: 1.39 MB
ℹ️ View Unchanged
|
85f7f25 to
d79b03e
Compare
dratwas
reviewed
Jan 22, 2021
packages/block-editor/src/components/block-list/block.native.js
Outdated
Show resolved
Hide resolved
dratwas
approved these changes
Jan 25, 2021
This was referenced Apr 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: wordpress-mobile/gutenberg-mobile#2962
This PR introduces improvements in settings block width where after changes it's measured at the top and passed to bottom component by props.
It allows to avoid redundant renders related to setting the block width which actually doesn't change.
Mounting time of example post on Android emulator (google pixel 3) was decreased from ~9.5s to ~7.5s
How has this been tested?
Copy the content from initial.html file (except the Cover, since there is some kind of issue) and explore all the blocks.
Expect there is no crash and blocks are rendered properly.
Select each block, change its alignment to
Full Widthif there is an options.Expect that blocks extend.
Rotate the device.
Expect that blocks extend.
Screenshots
Types of changes
Performance improvements
Checklist: