Skip to content

[RNMobile] Fix List block's e2e test#28286

Merged
cameronvoell merged 15 commits intoWordPress:masterfrom
fluiddot:rnmobile/fix/e2e-list-block
Jan 18, 2021
Merged

[RNMobile] Fix List block's e2e test#28286
cameronvoell merged 15 commits intoWordPress:masterfrom
fluiddot:rnmobile/fix/e2e-list-block

Conversation

@fluiddot
Copy link
Copy Markdown
Contributor

@fluiddot fluiddot commented Jan 18, 2021

gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#3014

Description

Native e2e tests use the title prop of toolbar buttons as the ID for querying them in Appium, in a recent PR the value of Convert to ordered list button was changed and so the test is failing because it can't find the element.

Appium error:

Error: [elementByAccessibilityId("Convert to ordered list")] Error response status: 7, 
NoSuchElement - An element could not be located on the page using the given search parameters.

Since the value changed the fix has only implied to update the value.

How has this been tested?

This PR can be tested by running the List block's native e2e test for each platform:

  1. Run: cd packages/react-native-editor
  2. For Android run: npm run test:e2e:android:local gutenberg-editor-lists-@canary
  3. For iOS run: npm run test:e2e:ios:local gutenberg-editor-lists-@canary

For more information about running e2e tests, check UI tests instructions (aka e2e tests).

Screenshots

iOS:
Screenshot 2021-01-18 at 13 36 50

Android:
android-e2e-test

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Update `master` branch from original repo.
Update master branch from original repo
Update master branch from original repo.
Update master branch from original repo
Update master branch from original repo.
Update master branch from original repo
Update master branch from original repo
Update master branch from original repo
Update master branch from original repo
Update master branch from original repo
Update master branch from original repo
Update master branch from original repo
Update master branch from original repo
Update master branch from original repo
The title for this button has changed so we have to update the value in the e2e tests.
@cameronvoell cameronvoell self-requested a review January 18, 2021 18:43
Copy link
Copy Markdown
Member

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via wordpress-mobile/gutenberg-mobile#3014 (review) . CI is now passing for gb-mobile. Thanks for the fix @fluiddot !

@cameronvoell cameronvoell merged commit ea48942 into WordPress:master Jan 18, 2021
@github-actions github-actions bot added this to the Gutenberg 9.9 milestone Jan 18, 2021
@fluiddot fluiddot deleted the rnmobile/fix/e2e-list-block branch January 19, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants