[RNMobile] Performance improvements in Buttons, Image and SocialLinks related controls#28238
Merged
lukewalczak merged 11 commits intomasterfrom Feb 8, 2021
Merged
[RNMobile] Performance improvements in Buttons, Image and SocialLinks related controls#28238lukewalczak merged 11 commits intomasterfrom
lukewalczak merged 11 commits intomasterfrom
Conversation
6 tasks
6edd623 to
c5372f0
Compare
|
Size Change: +2.54 kB (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
dratwas
requested changes
Jan 25, 2021
packages/block-library/src/buttons/content-justification-dropdown.js
Outdated
Show resolved
Hide resolved
packages/components/src/mobile/cycle-select-control/index.native.js
Outdated
Show resolved
Hide resolved
packages/components/src/mobile/link-settings/link-settings-navigation.native.js
Outdated
Show resolved
Hide resolved
dratwas
requested changes
Feb 4, 2021
packages/components/src/mobile/link-settings/link-settings-screen.native.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com>
dratwas
approved these changes
Feb 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after
CoverPR: #28235Description
Part of: #28196
Contains changes only related to the
Image,ButtonandSocialLinksblocks and controls available within block settings and inherit changes fromCoverPR.These 3 blocks are grouped in one PR since using the same control called
LinkSettingswhere previously passedattributesobject is replaced in favour of passing separate attributes.BlockStylesCycleSelectControlTextControlFooterMessageControlLinkSettingsTextControlTextControlToggleControlTextControlFooterMessageControlPanelActionsColorEditRangeControlLinkSettingsTextControlTextControlToggleControlTextControlFooterMessageControlPanelActionsLinkSettingsTextControlTextControlHow has this been tested?
Do sanity testing for
Image,ButtonandSocialIconsblocks using instructions from test casesScreenshots
RESULTS
1. Image - change image style
2. Image - change image size
3. Image - add character in
alt4. Buttons - change radius
5. Social Icons - add character in label
Types of changes
Performance improvements
Checklist: