Add some basic e2e tests for the widgets screen#28160
Merged
kevin940726 merged 8 commits intomasterfrom Jan 14, 2021
Merged
Conversation
|
Size Change: +188 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
da4ad6a to
5b3d1c8
Compare
noisysocks
reviewed
Jan 14, 2021
Member
noisysocks
left a comment
There was a problem hiding this comment.
Nice work! I think we should look at snapshotting the actual widget entities (getWidgets()) instead of the block representation (getWidgetAreas()). Other than that, this looks good as something that we can merge and iterate on in follow-up PRs.
| } ); | ||
|
|
||
| beforeAll( async () => { | ||
| // TODO: Ideally we can bundle our test theme directly in the repo. |
Member
There was a problem hiding this comment.
There's some prior art here with the tt1-blocks theme which is used to test FSE.
Line 6 in d61dccc
We can look into it later, though. It's more important that we get some tests for widgets in right now 🙂
Member
Author
There was a problem hiding this comment.
Yeah, I'm aware of that, but figured we should do it in a following PR 👍 .
| await activateTheme( 'twentytwentyone' ); | ||
| } ); | ||
|
|
||
| async function getParagraphBlockInGlobalInserter() { |
Member
There was a problem hiding this comment.
Nit: Why are some of these helper functions at the top here and some at the bottom of the file? 😀
Member
Author
There was a problem hiding this comment.
It's just a pattern more aligned to my mental model 😆 . Functions here are regular utility functions, but functions at the bottom should eventually be moved to the e2e-test-utils package once they're stable.
noisysocks
approved these changes
Jan 14, 2021
Member
noisysocks
left a comment
There was a problem hiding this comment.
It's a great start! Nice work.
kevin940726
commented
Jan 14, 2021
Comment on lines
+69
to
+72
| // TODO: Probably need a more accessible way to select this, maybe a test ID or data attribute. | ||
| const insertionPointIndicator = await page.$( | ||
| '.block-editor-block-list__insertion-point-indicator' | ||
| ); |
kevin940726
commented
Jan 14, 2021
Comment on lines
+89
to
+92
| // FIXME: The insertion point indicator is not showing when the widget area has no blocks. | ||
| // await expectInsertionPointIndicatorToBeBelowLastBlock( | ||
| // firstWidgetArea | ||
| // ); |
Member
Author
There was a problem hiding this comment.
See #28123.
Also, unless there are multiple widgets in a sidebar area, I'm unable to get the in-between inserter to appear.
|
|
||
| beforeAll( async () => { | ||
| // TODO: Ideally we can bundle our test theme directly in the repo. | ||
| await activateTheme( 'twentytwenty' ); |
Contributor
There was a problem hiding this comment.
Why specifically TwentyTwenty?
Member
Author
There was a problem hiding this comment.
It just happens to have 2 widget areas so that we can test DnD and some other stuffs more easily 😅 .
Contributor
|
Thanks for the test Should we move it to |
6 tasks
Member
Author
|
@youknowriad Ahh got it, I didn't know what it means and where to put this, and seems like most of us don't know 😆 : #28160 (comment). |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #25784.
An attempt to add some basic e2e tests for the widgets screen following the rules in #27260 but without introducing a new library yet.
The selectors are mostly using aria attributes or human-readable text, to simulate what the actual users see/read. Some exceptions are made to use
dataattribute where there's no stable a11y queries available.You will see a lot of
TODOs andFIXMEs here 😅. We're planning to fix them in following PRs or open issues.The top priority for this PR is to make sure the tests pass consistently.
How has this been tested?
Types of changes
Bug fix
Checklist: