Show the spacer block background on hover.#28129
Merged
draganescu merged 1 commit intomasterfrom Jan 14, 2021
Merged
Conversation
|
Size Change: +90 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
aristath
approved these changes
Jan 14, 2021
Member
aristath
left a comment
There was a problem hiding this comment.
LGTM 👍
Great enhancement, thank you! Spacer blocks are pretty hard to perceive, this PR makes things a lot easier.
This was referenced Feb 22, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spacer block is useful. But when you're in the site editor and hovering blocks, it doesn't appear visually as a spacer. This issue is inspired by this video: https://wordpress.slack.com/archives/C015GUFFC00/p1610073841174300, thank you to @brentjett @cdils.
This PR changes it so that the spacer background color is visible not just when you select the block, but when you hover it too.
Before:
After:
This is just one small step, and I would like to see global styles expanding the range of capabilities with regards to margins and paddings, so spacers can be used less. But in the mean time, this might improve things slightly.
Edit: the GIF recording tool did not capture the hover style at all, the compression was too high, so I replaced with screenshots.