Edit Widgets: Replace store name string with exposed store definition#28044
Merged
Edit Widgets: Replace store name string with exposed store definition#28044
Conversation
|
Size Change: -15 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Jan 7, 2021
Member
There was a problem hiding this comment.
Didn't we create a file that exports the constant with the name of the store to avoid cyclic dependencies between files in other packages for the store implementation?
Contributor
Author
There was a problem hiding this comment.
My bad, that's true. Fixing it.
Member
There was a problem hiding this comment.
I think you updated too much. I meant only all files inside edit-widgets/src/store/*. It's perfectly fine to reference editWidgetsStore imported from edit-wdigets/src/store/index/js from files in edit-widgets/src/components/* and the rest 😄
Contributor
Author
There was a problem hiding this comment.
Oh, I see... I thought that referencing the store inside its own package could also cause cyclic dependencies somehow... I'll fix it by tomorrow. Sorry for the confusion, I kinda did it in a hurry 😅...
Member
There was a problem hiding this comment.
No worries. I really appreciate all your work done some far, you rock 🥇
gziolo
approved these changes
Jan 7, 2021
Member
gziolo
left a comment
There was a problem hiding this comment.
Looks good to me. There is one thing to check as pointed out in the comment.
17 tasks
2ec622e to
e97fbe7
Compare
e97fbe7 to
eb9e5fd
Compare
gziolo
approved these changes
Jan 9, 2021
Member
|
Thank you for addressing all feedback 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #27088. Replaces the store names (hardcoded strings) with the exposed
storedefinitions.How has this been tested?
npm run test.Types of changes
Code refactoring, non-breaking change.
Checklist: