Try: simplify focus return#27705
Merged
Merged
Conversation
|
Size Change: -36 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
80f3a56 to
a73b78a
Compare
a73b78a to
ea1a93e
Compare
ellatrix
commented
Dec 14, 2020
| // Unmounting the reference | ||
| if ( ! newNode && focusedBeforeMount.current ) { | ||
| if ( newNode?.ownerDocument ) { | ||
| newNode.ownerDocument.removeEventListener( |
Member
Author
There was a problem hiding this comment.
This PR also fixes a memory leak. This line will never execute and even if it did, updateLastFocusedRef will be a different function because it is different every time the ref callback is called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The focus event listener seems unnecessary to me because at the time of a component unmounting, we can check the active element.
The behaviour should be exactly the same otherwise.
How has this been tested?
Screenshots
Types of changes
Checklist: