Refactor focus on mount by ellatrix · Pull Request #27699 · WordPress/gutenberg

ellatrix · 2020-12-12T17:45:59Z

Description

Alternative refactor. Let's see if the e2e tests need the timeout, manual testing works fine.

How has this been tested?

Screenshots

Types of changes

Checklist:

My code is tested.
My code follows the WordPress code style.
My code follows the accessibility standards.
My code has proper inline documentation.
I've included developer documentation if appropriate.
I've updated all React Native files affected by any refactorings/renamings in this PR.

github-actions · 2020-12-12T17:54:47Z

Size Change: -37 B (0%)

Total Size: 1.28 MB

Filename	Size	Change
`build/compose/index.js`	11 kB	-37 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
`build/a11y/index.js`	1.14 kB	0 B
`build/annotations/index.js`	3.8 kB	0 B
`build/api-fetch/index.js`	3.42 kB	0 B
`build/autop/index.js`	2.84 kB	0 B
`build/blob/index.js`	665 B	0 B
`build/block-directory/index.js`	8.72 kB	0 B
`build/block-directory/style-rtl.css`	943 B	0 B
`build/block-directory/style.css`	942 B	0 B
`build/block-editor/index.js`	128 kB	0 B
`build/block-editor/style-rtl.css`	11.2 kB	0 B
`build/block-editor/style.css`	11.2 kB	0 B
`build/block-library/blocks/archives/editor-rtl.css`	120 B	0 B
`build/block-library/blocks/archives/editor.css`	119 B	0 B
`build/block-library/blocks/audio/editor-rtl.css`	118 B	0 B
`build/block-library/blocks/audio/editor.css`	118 B	0 B
`build/block-library/blocks/audio/style-rtl.css`	152 B	0 B
`build/block-library/blocks/audio/style.css`	152 B	0 B
`build/block-library/blocks/block/editor-rtl.css`	211 B	0 B
`build/block-library/blocks/block/editor.css`	211 B	0 B
`build/block-library/blocks/button/editor-rtl.css`	513 B	0 B
`build/block-library/blocks/button/editor.css`	513 B	0 B
`build/block-library/blocks/button/style-rtl.css`	488 B	0 B
`build/block-library/blocks/button/style.css`	488 B	0 B
`build/block-library/blocks/buttons/editor-rtl.css`	275 B	0 B
`build/block-library/blocks/buttons/editor.css`	275 B	0 B
`build/block-library/blocks/buttons/style-rtl.css`	346 B	0 B
`build/block-library/blocks/buttons/style.css`	346 B	0 B
`build/block-library/blocks/calendar/style-rtl.css`	249 B	0 B
`build/block-library/blocks/calendar/style.css`	249 B	0 B
`build/block-library/blocks/categories/editor-rtl.css`	135 B	0 B
`build/block-library/blocks/categories/editor.css`	135 B	0 B
`build/block-library/blocks/categories/style-rtl.css`	132 B	0 B
`build/block-library/blocks/categories/style.css`	132 B	0 B
`build/block-library/blocks/code/style-rtl.css`	152 B	0 B
`build/block-library/blocks/code/style.css`	152 B	0 B
`build/block-library/blocks/columns/editor-rtl.css`	239 B	0 B
`build/block-library/blocks/columns/editor.css`	239 B	0 B
`build/block-library/blocks/columns/style-rtl.css`	467 B	0 B
`build/block-library/blocks/columns/style.css`	466 B	0 B
`build/block-library/blocks/cover/editor-rtl.css`	440 B	0 B
`build/block-library/blocks/cover/editor.css`	438 B	0 B
`build/block-library/blocks/cover/style-rtl.css`	1.27 kB	0 B
`build/block-library/blocks/cover/style.css`	1.27 kB	0 B
`build/block-library/blocks/embed/editor-rtl.css`	529 B	0 B
`build/block-library/blocks/embed/editor.css`	529 B	0 B
`build/block-library/blocks/embed/style-rtl.css`	419 B	0 B
`build/block-library/blocks/embed/style.css`	419 B	0 B
`build/block-library/blocks/file/editor-rtl.css`	246 B	0 B
`build/block-library/blocks/file/editor.css`	245 B	0 B
`build/block-library/blocks/file/style-rtl.css`	288 B	0 B
`build/block-library/blocks/file/style.css`	289 B	0 B
`build/block-library/blocks/freeform/editor-rtl.css`	2.49 kB	0 B
`build/block-library/blocks/freeform/editor.css`	2.49 kB	0 B
`build/block-library/blocks/gallery/editor-rtl.css`	692 B	0 B
`build/block-library/blocks/gallery/editor.css`	693 B	0 B
`build/block-library/blocks/gallery/style-rtl.css`	1.11 kB	0 B
`build/block-library/blocks/gallery/style.css`	1.11 kB	0 B
`build/block-library/blocks/group/editor-rtl.css`	364 B	0 B
`build/block-library/blocks/group/editor.css`	364 B	0 B
`build/block-library/blocks/group/style-rtl.css`	117 B	0 B
`build/block-library/blocks/group/style.css`	117 B	0 B
`build/block-library/blocks/heading/editor-rtl.css`	174 B	0 B
`build/block-library/blocks/heading/editor.css`	174 B	0 B
`build/block-library/blocks/heading/style-rtl.css`	137 B	0 B
`build/block-library/blocks/heading/style.css`	137 B	0 B
`build/block-library/blocks/html/editor-rtl.css`	324 B	0 B
`build/block-library/blocks/html/editor.css`	325 B	0 B
`build/block-library/blocks/image/editor-rtl.css`	738 B	0 B
`build/block-library/blocks/image/editor.css`	737 B	0 B
`build/block-library/blocks/image/style-rtl.css`	510 B	0 B
`build/block-library/blocks/image/style.css`	511 B	0 B
`build/block-library/blocks/latest-comments/editor-rtl.css`	201 B	0 B
`build/block-library/blocks/latest-comments/editor.css`	200 B	0 B
`build/block-library/blocks/latest-comments/style-rtl.css`	315 B	0 B
`build/block-library/blocks/latest-comments/style.css`	315 B	0 B
`build/block-library/blocks/latest-posts/editor-rtl.css`	183 B	0 B
`build/block-library/blocks/latest-posts/editor.css`	183 B	0 B
`build/block-library/blocks/latest-posts/style-rtl.css`	568 B	0 B
`build/block-library/blocks/latest-posts/style.css`	567 B	0 B
`build/block-library/blocks/list/editor-rtl.css`	129 B	0 B
`build/block-library/blocks/list/editor.css`	129 B	0 B
`build/block-library/blocks/list/style-rtl.css`	127 B	0 B
`build/block-library/blocks/list/style.css`	127 B	0 B
`build/block-library/blocks/media-text/editor-rtl.css`	240 B	0 B
`build/block-library/blocks/media-text/editor.css`	240 B	0 B
`build/block-library/blocks/media-text/style-rtl.css`	579 B	0 B
`build/block-library/blocks/media-text/style.css`	577 B	0 B
`build/block-library/blocks/more/editor-rtl.css`	479 B	0 B
`build/block-library/blocks/more/editor.css`	479 B	0 B
`build/block-library/blocks/navigation-link/editor-rtl.css`	438 B	0 B
`build/block-library/blocks/navigation-link/editor.css`	440 B	0 B
`build/block-library/blocks/navigation-link/style-rtl.css`	747 B	0 B
`build/block-library/blocks/navigation-link/style.css`	745 B	0 B
`build/block-library/blocks/navigation/editor-rtl.css`	1.31 kB	0 B
`build/block-library/blocks/navigation/editor.css`	1.31 kB	0 B
`build/block-library/blocks/navigation/style-rtl.css`	222 B	0 B
`build/block-library/blocks/navigation/style.css`	222 B	0 B
`build/block-library/blocks/nextpage/editor-rtl.css`	440 B	0 B
`build/block-library/blocks/nextpage/editor.css`	440 B	0 B
`build/block-library/blocks/paragraph/editor-rtl.css`	161 B	0 B
`build/block-library/blocks/paragraph/editor.css`	161 B	0 B
`build/block-library/blocks/paragraph/style-rtl.css`	279 B	0 B
`build/block-library/blocks/paragraph/style.css`	279 B	0 B
`build/block-library/blocks/post-author/editor-rtl.css`	255 B	0 B
`build/block-library/blocks/post-author/editor.css`	255 B	0 B
`build/block-library/blocks/post-author/style-rtl.css`	229 B	0 B
`build/block-library/blocks/post-author/style.css`	230 B	0 B
`build/block-library/blocks/post-content/editor-rtl.css`	187 B	0 B
`build/block-library/blocks/post-content/editor.css`	187 B	0 B
`build/block-library/blocks/post-excerpt/editor-rtl.css`	134 B	0 B
`build/block-library/blocks/post-excerpt/editor.css`	134 B	0 B
`build/block-library/blocks/post-featured-image/editor-rtl.css`	387 B	0 B
`build/block-library/blocks/post-featured-image/editor.css`	386 B	0 B
`build/block-library/blocks/post-featured-image/style-rtl.css`	149 B	0 B
`build/block-library/blocks/post-featured-image/style.css`	149 B	0 B
`build/block-library/blocks/pullquote/editor-rtl.css`	231 B	0 B
`build/block-library/blocks/pullquote/editor.css`	231 B	0 B
`build/block-library/blocks/pullquote/style-rtl.css`	359 B	0 B
`build/block-library/blocks/pullquote/style.css`	359 B	0 B
`build/block-library/blocks/query-loop/editor-rtl.css`	142 B	0 B
`build/block-library/blocks/query-loop/editor.css`	141 B	0 B
`build/block-library/blocks/query-loop/style-rtl.css`	361 B	0 B
`build/block-library/blocks/query-loop/style.css`	363 B	0 B
`build/block-library/blocks/query/editor-rtl.css`	179 B	0 B
`build/block-library/blocks/query/editor.css`	179 B	0 B
`build/block-library/blocks/quote/editor-rtl.css`	121 B	0 B
`build/block-library/blocks/quote/editor.css`	121 B	0 B
`build/block-library/blocks/quote/style-rtl.css`	215 B	0 B
`build/block-library/blocks/quote/style.css`	214 B	0 B
`build/block-library/blocks/rss/editor-rtl.css`	270 B	0 B
`build/block-library/blocks/rss/editor.css`	270 B	0 B
`build/block-library/blocks/rss/style-rtl.css`	314 B	0 B
`build/block-library/blocks/rss/style.css`	313 B	0 B
`build/block-library/blocks/search/editor-rtl.css`	213 B	0 B
`build/block-library/blocks/search/editor.css`	213 B	0 B
`build/block-library/blocks/search/style-rtl.css`	384 B	0 B
`build/block-library/blocks/search/style.css`	386 B	0 B
`build/block-library/blocks/separator/editor-rtl.css`	151 B	0 B
`build/block-library/blocks/separator/editor.css`	151 B	0 B
`build/block-library/blocks/separator/style-rtl.css`	281 B	0 B
`build/block-library/blocks/separator/style.css`	281 B	0 B
`build/block-library/blocks/shortcode/editor-rtl.css`	547 B	0 B
`build/block-library/blocks/shortcode/editor.css`	547 B	0 B
`build/block-library/blocks/site-logo/editor-rtl.css`	251 B	0 B
`build/block-library/blocks/site-logo/editor.css`	251 B	0 B
`build/block-library/blocks/site-logo/style-rtl.css`	166 B	0 B
`build/block-library/blocks/site-logo/style.css`	166 B	0 B
`build/block-library/blocks/social-link/editor-rtl.css`	211 B	0 B
`build/block-library/blocks/social-link/editor.css`	211 B	0 B
`build/block-library/blocks/social-links/editor-rtl.css`	749 B	0 B
`build/block-library/blocks/social-links/editor.css`	749 B	0 B
`build/block-library/blocks/social-links/style-rtl.css`	1.37 kB	0 B
`build/block-library/blocks/social-links/style.css`	1.37 kB	0 B
`build/block-library/blocks/spacer/editor-rtl.css`	321 B	0 B
`build/block-library/blocks/spacer/editor.css`	321 B	0 B
`build/block-library/blocks/spacer/style-rtl.css`	107 B	0 B
`build/block-library/blocks/spacer/style.css`	107 B	0 B
`build/block-library/blocks/subhead/editor-rtl.css`	148 B	0 B
`build/block-library/blocks/subhead/editor.css`	148 B	0 B
`build/block-library/blocks/subhead/style-rtl.css`	134 B	0 B
`build/block-library/blocks/subhead/style.css`	134 B	0 B
`build/block-library/blocks/table/editor-rtl.css`	530 B	0 B
`build/block-library/blocks/table/editor.css`	530 B	0 B
`build/block-library/blocks/table/style-rtl.css`	433 B	0 B
`build/block-library/blocks/table/style.css`	433 B	0 B
`build/block-library/blocks/tag-cloud/editor-rtl.css`	162 B	0 B
`build/block-library/blocks/tag-cloud/editor.css`	162 B	0 B
`build/block-library/blocks/tag-cloud/style-rtl.css`	145 B	0 B
`build/block-library/blocks/tag-cloud/style.css`	145 B	0 B
`build/block-library/blocks/template-part/editor-rtl.css`	644 B	0 B
`build/block-library/blocks/template-part/editor.css`	645 B	0 B
`build/block-library/blocks/text-columns/editor-rtl.css`	146 B	0 B
`build/block-library/blocks/text-columns/editor.css`	146 B	0 B
`build/block-library/blocks/text-columns/style-rtl.css`	209 B	0 B
`build/block-library/blocks/text-columns/style.css`	209 B	0 B
`build/block-library/blocks/verse/editor-rtl.css`	153 B	0 B
`build/block-library/blocks/verse/editor.css`	153 B	0 B
`build/block-library/blocks/verse/style-rtl.css`	117 B	0 B
`build/block-library/blocks/verse/style.css`	117 B	0 B
`build/block-library/blocks/video/editor-rtl.css`	547 B	0 B
`build/block-library/blocks/video/editor.css`	548 B	0 B
`build/block-library/blocks/video/style-rtl.css`	241 B	0 B
`build/block-library/blocks/video/style.css`	241 B	0 B
`build/block-library/common-rtl.css`	940 B	0 B
`build/block-library/common.css`	937 B	0 B
`build/block-library/editor-rtl.css`	9.07 kB	0 B
`build/block-library/editor.css`	9.07 kB	0 B
`build/block-library/index.js`	150 kB	0 B
`build/block-library/style-rtl.css`	8.34 kB	0 B
`build/block-library/style.css`	8.34 kB	0 B
`build/block-library/theme-rtl.css`	789 B	0 B
`build/block-library/theme.css`	790 B	0 B
`build/block-serialization-default-parser/index.js`	1.88 kB	0 B
`build/block-serialization-spec-parser/index.js`	3.06 kB	0 B
`build/blocks/index.js`	48.1 kB	0 B
`build/components/index.js`	171 kB	0 B
`build/components/style-rtl.css`	15.4 kB	0 B
`build/components/style.css`	15.4 kB	0 B
`build/core-data/index.js`	15.4 kB	0 B
`build/data-controls/index.js`	827 B	0 B
`build/data/index.js`	8.98 kB	0 B
`build/date/index.js`	31.8 kB	0 B
`build/deprecated/index.js`	768 B	0 B
`build/dom-ready/index.js`	571 B	0 B
`build/dom/index.js`	4.95 kB	0 B
`build/edit-navigation/index.js`	11.1 kB	0 B
`build/edit-navigation/style-rtl.css`	881 B	0 B
`build/edit-navigation/style.css`	885 B	0 B
`build/edit-post/index.js`	306 kB	0 B
`build/edit-post/style-rtl.css`	6.47 kB	0 B
`build/edit-post/style.css`	6.45 kB	0 B
`build/edit-site/index.js`	24.4 kB	0 B
`build/edit-site/style-rtl.css`	3.91 kB	0 B
`build/edit-site/style.css`	3.91 kB	0 B
`build/edit-widgets/index.js`	26.3 kB	0 B
`build/edit-widgets/style-rtl.css`	3.1 kB	0 B
`build/edit-widgets/style.css`	3.1 kB	0 B
`build/editor/editor-styles-rtl.css`	476 B	0 B
`build/editor/editor-styles.css`	478 B	0 B
`build/editor/index.js`	43.3 kB	0 B
`build/editor/style-rtl.css`	3.84 kB	0 B
`build/editor/style.css`	3.84 kB	0 B
`build/element/index.js`	4.63 kB	0 B
`build/escape-html/index.js`	735 B	0 B
`build/format-library/index.js`	6.73 kB	0 B
`build/format-library/style-rtl.css`	547 B	0 B
`build/format-library/style.css`	548 B	0 B
`build/hooks/index.js`	2.27 kB	0 B
`build/html-entities/index.js`	622 B	0 B
`build/i18n/index.js`	3.57 kB	0 B
`build/is-shallow-equal/index.js`	698 B	0 B
`build/keyboard-shortcuts/index.js`	2.54 kB	0 B
`build/keycodes/index.js`	1.94 kB	0 B
`build/list-reusable-blocks/index.js`	3.1 kB	0 B
`build/list-reusable-blocks/style-rtl.css`	476 B	0 B
`build/list-reusable-blocks/style.css`	476 B	0 B
`build/media-utils/index.js`	5.32 kB	0 B
`build/notices/index.js`	1.86 kB	0 B
`build/nux/index.js`	3.42 kB	0 B
`build/nux/style-rtl.css`	671 B	0 B
`build/nux/style.css`	668 B	0 B
`build/plugins/index.js`	2.54 kB	0 B
`build/primitives/index.js`	1.43 kB	0 B
`build/priority-queue/index.js`	789 B	0 B
`build/redux-routine/index.js`	2.84 kB	0 B
`build/reusable-blocks/index.js`	2.92 kB	0 B
`build/rich-text/index.js`	13.4 kB	0 B
`build/server-side-render/index.js`	2.77 kB	0 B
`build/shortcode/index.js`	1.7 kB	0 B
`build/token-list/index.js`	1.27 kB	0 B
`build/url/index.js`	2.84 kB	0 B
`build/viewport/index.js`	1.86 kB	0 B
`build/warning/index.js`	1.14 kB	0 B
`build/wordcount/index.js`	1.22 kB	0 B

_{compressed-size-action}

ellatrix requested a review from ajitbohra as a code owner December 12, 2020 17:46

This was referenced Dec 12, 2020

Add a useFocusOnMount hook to the @wordpress/compose package. #27574

Merged

Refactor focus on mount #27698

Closed

Refactor focus on mount (2)

5fb74bb

ellatrix force-pushed the try/focus-on-mount-refactor branch from d762b8d to 5fb74bb Compare December 14, 2020 18:32

Clean up

571ba63

ellatrix requested a review from chrisvanpatten as a code owner December 14, 2020 19:07

Update doc

f829970

ellatrix changed the title ~~Refactor focus on mount (2)~~ Refactor focus on mount Dec 14, 2020

ellatrix merged commit 60011ce into master Dec 14, 2020

ellatrix deleted the try/focus-on-mount-refactor branch December 14, 2020 20:37

github-actions bot added this to the Gutenberg 9.6 milestone Dec 14, 2020

youknowriad mentioned this pull request Dec 16, 2020

Fix useFocusOnMount #27754

Merged

fernandovbs mentioned this pull request May 15, 2021

Update/modal component #19997

Closed

This was referenced Jun 30, 2022

Block options menu: initial focus skips the first menu item #42064

Closed

Make sure useFocusOnMount runs when all the children tabbable elements have mounted #42187

Merged

ciampo mentioned this pull request Sep 6, 2022

Popover: refactor to TypeScript #43823

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor focus on mount#27699

Refactor focus on mount#27699
ellatrix merged 3 commits intomasterfrom
try/focus-on-mount-refactor

ellatrix commented Dec 12, 2020 •

edited

Loading

Uh oh!

github-actions bot commented Dec 12, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

ellatrix commented Dec 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

Uh oh!

github-actions bot commented Dec 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ellatrix commented Dec 12, 2020 •

edited

Loading

github-actions bot commented Dec 12, 2020 •

edited

Loading