Conversation
Merged
2 tasks
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
lukewalczak
approved these changes
Dec 14, 2020
Member
lukewalczak
left a comment
There was a problem hiding this comment.
LGTM, additionally I compared it with web and it behaves the same. Thanks for a fix 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#2879
Description
Currently when you go and modify the rel link text of the button component and toggle the "Open in new tab" toggle the text either gets completely removed or overwritten by the text "noreferrer noopener" which is not expected for me.
This PR fixes it so that it works more like expected.
This PR fixes this my using the most up to date value of the "Rel" input instead of the one that exists when the "Link Setting" are shown.
How has this been tested?
I tested this in the demo app.
Screenshots
https://cloudup.com/cNHD2ns__oK
Types of changes
Bug fix.
Checklist: