[RNMobile] Add block insertion flow e2e test#27381
Merged
Conversation
2 tasks
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
59eb778 to
d3761e0
Compare
cameronvoell
approved these changes
Dec 31, 2020
Member
cameronvoell
left a comment
There was a problem hiding this comment.
Changes look good. Nice job adding the block insertion tests 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
testNamePatternwas used to run/skip tests. UsedtestPathPatterninstead changing the names of tests to make sure the setup is also skipped when tests are skipped.Show htmlbutton on Android using XPath.Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#2851
How has this been tested?
npm run native test:e2e:ios:localandnpm run native test:e2e:android:localshould work as before.Checklist: