Search Block: Add rounded block style#27220
Conversation
39a7e2d to
25dc4b2
Compare
|
Size Change: +135 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
|
This tested well for me, my only question was whether there should be some extra padding on left of placeholder text when rounded chosen as text looks slightly odd at the edge of the radius, eg. Might just be a personal opinion thing so not critical I don't think |
Agreed, I'll make that update. I'm also still waiting to see if we go down this path, a separate border radius control to allow custom radius values or the full block support approach. #25791 (comment) |
aristath
left a comment
There was a problem hiding this comment.
Code looks good, and testing it everything seems to be OK.
If we decide to go with this implementation instead of a separate border-radius control this looks OK to merge 👍
There was a problem hiding this comment.
I don't think this is the direction we should go in because designers should have more fine grained control of border radius than this in order to create interesting patterns. Other examples of this need are here and here.
For now I think we should merge the block support for border radius and hold off on this.


Description
Adds a new rounded block style for the search block. This will add a border radius to the search block including adding adjusted border radii to the input and button when the button is placed "inside".
This is an alternate approach to adding border radius block support as suggested in #25791 (comment)
Note: This uses a CSS variable for the border radius value. This allows;
calc()for inner elementsHow has this been tested?
Manually.
Screenshots
Types of changes
New feature.
Checklist: