Skip to content

Block Directory: Replace store name string with exposed store definition#27178

Merged
gziolo merged 2 commits intoWordPress:masterfrom
rafaelgallani:refactor/replace-block-dir-store-key-with-store-def
Nov 24, 2020
Merged

Block Directory: Replace store name string with exposed store definition#27178
gziolo merged 2 commits intoWordPress:masterfrom
rafaelgallani:refactor/replace-block-dir-store-key-with-store-def

Conversation

@rafaelgallani
Copy link
Copy Markdown
Contributor

@rafaelgallani rafaelgallani commented Nov 22, 2020

Description

Addresses #27088. Replaces the store names (hardcoded strings) with the exposed store definitions.

How has this been tested?

npm run test, no additional test was done.

Screenshots

image

Types of changes

Code refactoring, non-breaking change.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 22, 2020
@gziolo gziolo added [Type] Code Quality Issues or PRs that relate to code quality [Feature] Block Directory Related to the Block Directory, a repository of block plugins labels Nov 22, 2020
@gziolo gziolo self-requested a review November 22, 2020 08:05
@rafaelgallani
Copy link
Copy Markdown
Contributor Author

rafaelgallani commented Nov 23, 2020 •
edited
Loading

The build was failing before this last commit. I tried analyzing the YAML for the E2E tests; apparently, the runs are split between 4 runners... Right? And, for some reason (which I am not sure why), the build failed in the second one... I just made an empty commit, and it passed now...

Edit: after some quick searching, I think that the issue could be something similar to this.

gziolo
gziolo approved these changes Nov 24, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for proposing this refactoring 👍

@gziolo gziolo merged commit 3067e91 into WordPress:master Nov 24, 2020
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 24, 2020

Congratulations on your first merged pull request, @rafaelgalani! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 9.5 milestone Nov 24, 2020
@gziolo
Copy link
Copy Markdown
Member

gziolo commented Nov 24, 2020

The build was failing before this last commit. I tried analyzing the YAML for the E2E tests; apparently, the runs are split between 4 runners... Right? And, for some reason (which I am not sure why), the build failed in the second one... I just made an empty commit, and it passed now...

Edit: after some quick searching, I think that the issue could be something similar to this.

That's quite useful. I will file an issue for that 🙇‍♂️

@gziolo gziolo mentioned this pull request Nov 24, 2020
Closed
@gziolo gziolo changed the title Replace "core/block-directory" store name string with exposed store definition Block Directory: Replace store name string with exposed store definition Nov 24, 2020
@gziolo gziolo mentioned this pull request Nov 24, 2020
Closed
17 tasks
@rafaelgallani rafaelgallani mentioned this pull request Nov 25, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gziolo gziolo gziolo approved these changes

Assignees

No one assigned

Labels

[Feature] Block Directory Related to the Block Directory, a repository of block plugins First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Milestone

Gutenberg 9.5

Development

Successfully merging this pull request may close these issues.

2 participants

@rafaelgallani @gziolo