Components: Close popover by escape keypress#2697
Merged
Conversation
Click outside is handled internally by the Popover component
onClickOutside passes event which is relied upon by PostVisibility, but we don't want to guarantee this with signature of onClose
Codecov Report
@@ Coverage Diff @@
## master #2697 +/- ##
==========================================
+ Coverage 33.64% 33.67% +0.02%
==========================================
Files 185 185
Lines 5584 5591 +7
Branches 973 975 +2
==========================================
+ Hits 1879 1883 +4
- Misses 3138 3139 +1
- Partials 567 569 +2
Continue to review full report at Codecov.
|
This was referenced Sep 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #2323
This pull request seeks to enhance the Popover component to handle escape keypress and focus return for closing the focused dialog. This also helps consolidate existing but inconsistently-applied approaches for this behavior.
Testing instructions:
Verify that a focused popover can be closed by clicking outside or pressing escape. When pressing escape, observe that focus returns to the element which had been focused prior to opening the dialog.
(Repeat for Visibility, Schedule popovers)
Caveats:
When tabbing through to the end of a popover's tabbable elements, we should do one or the other of: