Site Editor: Fix Invisible Template Previews in the Sidebar#26424
Merged
Conversation
|
Size Change: +8 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
Contributor
|
Found an immediate z-index issue - might be hard to see, but it's the Post Title bleeding over. Still digging in but thought I'd put this in right away. |
vindl
approved these changes
Oct 23, 2020
vindl
left a comment
Member
There was a problem hiding this comment.
This looks good to me and tests well. 👍
I noticed something unrelated to this PR that we might want to follow up on: the content section is not displaying previews.
Contributor
|
This is working well on my end as well. I couldn't repro the z-index issue before, but it looks like the update should hopefully fix what @mattwiebe was noticing? |
Contributor
|
It looks as though it's a conflict with the Cover block in my testing:
|
Contributor
Author
|
@mattwiebe I can't repro the z-index issues as well, but I've raised the preview's from |
Contributor
|
@Copons - can confirm that it's working as expected now, sits on top of Cover and everything in it.
|
mattwiebe
approved these changes
Oct 23, 2020
Member
|
Nice catch @mattwiebe! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A recent change on the FSE navigation sidebar's overflow accidentally hid the templates (and template parts) previews that were supposed to appear when hovering on the sidebar items.
This PR moves the preview SlotFill outside of the sidebar hidden overflow, and reposition it accordingly.
How has this been tested?
Screenshot
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: