Add color palette edit functionality to global styles#25711
Merged
jorgefilipecosta merged 3 commits intomasterfrom Oct 7, 2020
Merged
Add color palette edit functionality to global styles#25711jorgefilipecosta merged 3 commits intomasterfrom
jorgefilipecosta merged 3 commits intomasterfrom
Conversation
|
Size Change: +1.73 kB (0%) Total Size: 1.18 MB
ℹ️ View Unchanged
|
Member
|
Just tested this one 👍 |
38eca3e to
bfc494a
Compare
Member
Author
There is an important related point: the state of having no user color palette (using the default/theme colors) and the state of the user intentionally setting an empty color palette are different. I added a button to allow the user to remove the user color palette and get back to defaults after removing all the colors. |
mcsf
approved these changes
Oct 7, 2020
Contributor
mcsf
left a comment
There was a problem hiding this comment.
Feels nice! Looking forward for the subsequent PRs for the rest of the system.
Comment on lines
+78
to
+84
| renderToggle={ ( { isOpen, onToggle } ) => ( | ||
| <> | ||
| <DropdownOpenOnMount | ||
| shouldOpen={ isEditingColorOnMount } | ||
| isOpen={ isOpen } | ||
| onToggle={ onToggle } | ||
| /> |
Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the user to configure a global color palette or even a color palette for a specific block.
Limitations
Screenshots
Tests
I added a custom color palette I saved the design and verified the colors were persisted.
I verified I could change the color code, name, and slug of existing colors.
I verified I could remove colors.