[Mobile] Checks theme colors for validity and fallbacks to defaults#25440
Merged
[Mobile] Checks theme colors for validity and fallbacks to defaults#25440
Conversation
Merged
2 tasks
|
Size Change: +94 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
chipsnyder
reviewed
Sep 18, 2020
Contributor
chipsnyder
left a comment
There was a problem hiding this comment.
Using Maywood I wasn't able to recreate this issue but overall the fix looks good just left a couple smaller suggestions
| import { getTranslation } from '../i18n-cache'; | ||
| import initialHtml from './initial-html'; | ||
| import setupApiFetch from './api-fetch-setup'; | ||
| import { SETTINGS_DEFAULTS } from '../../block-editor/src/store/defaults.js'; |
Contributor
There was a problem hiding this comment.
Hey @antonis, for imports from another module we usually would import SETTINGS_DEFAULTS like what's below.
Suggested change
| import { SETTINGS_DEFAULTS } from '../../block-editor/src/store/defaults.js'; | |
| import { SETTINGS_DEFAULTS } from '@wordpress/block-editor'; |
| gradients = validGradients; | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
This looks good overall. Since it's the same code in both places I wonder if we would be better off creating a helper that both modules could use. Maybe a function in the block-editor component as both spots reference that already
f04670f to
006cf34
Compare
Member
Author
|
Converted to DRAFT till we figure out how to handle the removal of default colors with #25419 |
Member
Author
This seems to be ok on CI. Probably something is wrong in my local setup. |
Contributor
|
@antonis could you try running |
chipsnyder
approved these changes
Sep 25, 2020
Contributor
chipsnyder
left a comment
There was a problem hiding this comment.
LGTM! I tested with the suggested theme and everything worked well 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#2635
Gutenberg Mobile PR-> wordpress-mobile/gutenberg-mobile#2639Description
How has this been tested?
Broken theme
Normal theme
Types of changes
Bug fix
Checklist: