Conversation
|
Size Change: +3 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
…ry-action-on-unsupported-blocks
etoledom
left a comment
There was a problem hiding this comment.
Thank you for this PR @marecar3 !
Code looks perfect. Nice job! ✨
About the behaviour, I think we are missing something. From the original ticket, @iamthomasbishop mentions this:
With this change, I think we will want to change the logic so that you first have to select the block before the tap target becomes "active", which follows some other similar blocks like the Latest Posts block, and most importantly, the select-first interaction gives the user the other block controls such as movers and the overflow (•••) menu.
What I see on the tests, is that pressing over the target area will open the bottom sheet directly, even if the block is not selected. What we would want instead is:
- When the block is not selected, pressing in the target area (or anywhere over the block) Will select the block.
- When the block is already selected, pressing in the target area will open the Bottom Sheet.
…ry-action-on-unsupported-blocks
Ok, it's clear. Thanks for bringing this up. I will fix it. |
Thanks for review! |
Description
Based on the issue: wordpress-mobile/gutenberg-mobile#2567
this PR introduces an increase of tap-target of primary action on unsupported blocks
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#2608How has this been tested?
Checklist: