Skip to content

Add title attribute to Navigation Link block.#24993

Merged
tellthemachines merged 1 commit into
masterfrom
add/link-block-title
Sep 2, 2020
Merged

Add title attribute to Navigation Link block.#24993
tellthemachines merged 1 commit into
masterfrom
add/link-block-title

Conversation

@tellthemachines

@tellthemachines tellthemachines commented Sep 2, 2020

Copy link
Copy Markdown
Contributor

Description

Partially addresses #23731 by adding the "title" attribute to the Navigation Link block.

How has this been tested?

Tested in browser.

Screenshots

Screen Shot 2020-09-02 at 11 30 13 am

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions

github-actions Bot commented Sep 2, 2020

Copy link
Copy Markdown

Size Change: +28 B (0%)

Total Size: 1.17 MB

Filename Size Change
build/block-library/index.js 137 kB +28 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.67 kB 0 B
build/api-fetch/index.js 3.44 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.99 kB 0 B
build/block-directory/style-rtl.css 953 B 0 B
build/block-directory/style.css 952 B 0 B
build/block-editor/index.js 126 kB 0 B
build/block-editor/style-rtl.css 10.8 kB 0 B
build/block-editor/style.css 10.8 kB 0 B
build/block-library/editor-rtl.css 8.55 kB 0 B
build/block-library/editor.css 8.55 kB 0 B
build/block-library/style-rtl.css 7.47 kB 0 B
build/block-library/style.css 7.47 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 742 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.7 kB 0 B
build/components/index.js 200 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 9.67 kB 0 B
build/core-data/index.js 12.3 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.55 kB 0 B
build/date/index.js 5.38 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.48 kB 0 B
build/edit-navigation/index.js 11.6 kB 0 B
build/edit-navigation/style-rtl.css 1.16 kB 0 B
build/edit-navigation/style.css 1.16 kB 0 B
build/edit-post/index.js 305 kB 0 B
build/edit-post/style-rtl.css 6.26 kB 0 B
build/edit-post/style.css 6.24 kB 0 B
build/edit-site/index.js 17 kB 0 B
build/edit-site/style-rtl.css 3.06 kB 0 B
build/edit-site/style.css 3.06 kB 0 B
build/edit-widgets/index.js 12 kB 0 B
build/edit-widgets/style-rtl.css 2.46 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/editor/index.js 45.4 kB 0 B
build/editor/style-rtl.css 3.81 kB 0 B
build/editor/style.css 3.81 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.71 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.32 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.41 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.9 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

kevin940726
kevin940726 approved these changes Sep 2, 2020
View reviewed changes

@kevin940726 kevin940726 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tellthemachines tellthemachines merged commit ab5cbfa into master Sep 2, 2020
@tellthemachines tellthemachines deleted the add/link-block-title branch September 2, 2020 05:30
@github-actions github-actions Bot added this to the Gutenberg 9.0 milestone Sep 2, 2020
@carolinan

carolinan commented Sep 2, 2020

Copy link
Copy Markdown
Contributor

Perhaps controversial, but I am wondering if there was any discussion about not supporting the title attribute? There is still an ongoing issue about removing title attributes from core.
https://core.trac.wordpress.org/ticket/24766

@tellthemachines

tellthemachines commented Sep 3, 2020

Copy link
Copy Markdown
Contributor Author

Great question! With this PR we're looking to replicate the functionality in the Menus screen (nav-menus.php), which includes the option to add link titles via "advanced menu properties" in "Screen options" at the top of the page. Because it's existing functionality, we don't want to break things for users who might depend on it.

If I read the ticket you linked to above correctly, it's about removing title attributes from the admin interface, not to stop users from adding them to their content. Whether to encourage users to not use these attributes is another question (and a good one!), but would be better addressed as a separate issue.

This was referenced Mar 18, 2021
Merged
Closed
Closed
Merged
Closed
Merged
Closed
@MaxMood96 MaxMood96 mentioned this pull request Jan 18, 2024
Open
@naiba4 naiba4 mentioned this pull request Jan 30, 2024
Open
@naiba4 naiba4 mentioned this pull request Apr 22, 2024
Open
@t-hamano t-hamano mentioned this pull request Mar 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevin940726 kevin940726 kevin940726 approved these changes
@ajitbohra ajitbohra Awaiting requested review from ajitbohra
@Soean Soean Awaiting requested review from Soean
@talldan talldan Awaiting requested review from talldan
@draganescu draganescu Awaiting requested review from draganescu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Gutenberg 9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tellthemachines @carolinan @kevin940726