Add unit tests for edit-navigation store#24681
Merged
kevin940726 merged 13 commits intomasterfrom Aug 26, 2020
Merged
Conversation
kevin940726
commented
Aug 20, 2020
kevin940726
commented
Aug 20, 2020
|
Size Change: +40 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Aug 26, 2020
Contributor
talldan
left a comment
There was a problem hiding this comment.
This is impressive, great work on this!
4898d50 to
3901371
Compare
3901371 to
8868697
Compare
Member
|
Heck yeah @kevin940726! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add unit tests for
edit-navigationstore. Close #21285.Most of the tests here should better be done in integration testing. However, we're lacking some ground up architecture for it to work elegantly in tests. We'll come back to it later, in the meantime, why not some unit tests first?
Also fixed some minor issues, see the comments below for more info.
How has this been tested?
Run the test via
npm run test-unitTypes of changes
New feature
Checklist: