Make "Attempt Block Recovery" the default option of block invalidation#24263
Merged
talldan merged 5 commits intoWordPress:masterfrom Jul 29, 2020
Merged
Conversation
talldan
reviewed
Jul 29, 2020
docs/designers-developers/developers/block-api/block-edit-save.md
Outdated
Show resolved
Hide resolved
talldan
approved these changes
Jul 29, 2020
Contributor
talldan
left a comment
There was a problem hiding this comment.
Changes look good, thanks for working on this.
Congrats on your first merged PR 🎉
|
Congratulations on your first merged pull request, @kevin940726! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #16425.
As stated in the original issue:
This PR makes Attempt Block Recovery the default option of block invalidation.
How has this been tested?
h2toh3Screenshots
Caveat
When opening the resolve dialog from the sub-menu of the "3-dots" menu icon, the modal dialog will be below the sub-menu itself, which looks like a bug.
I think we have 2 options to solve it:
z-indexof the modal dialog, but the sub-menu will still be opengutenberg/packages/components/src/dropdown/index.js
Lines 58 to 72 in a260cda
(1) doesn't really solve the problem but can be a hacky temporary solution. I believe we should go with (2) is possible. However, I think this is outside of this PR's scope, and I'm not sure what changes should be make?
In the end, we chose to go with (1). Since it looks like we cannot do (2) because of an accessibility issue.
The solution is to decrease the
z-indexvalue for all the dropdowns under the<Warning>component. As shown below.Types of changes
New feature
Checklist: