Add option to show icon labels.#24234
Conversation
|
As it stands, this option only applies to the post editor. But this is a setting that will also be useful in the site editor; is there a way we could make it apply in both places? It would be awkward to have an identical setting for each screen. |
|
Size Change: +31 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
|
The category inside Options "Icon Labels" could perhaps instead be named "Labels" as it would make it possible to later on add if needed additional label options inside this category. |
|
I'd change the option from "Show Icon Labels" to "Show button text labels". (Note capitalization.) |
|
Code looks great 👍, but I don't think we should add this option to the plugin before we have anything that uses it? It would be confusing, I think, to see this setting, click it, and not see anything happen. |
I agree, and the PR that adds this to the toolbar is coming up Very Soon. The reason I did it this way is the original PR to add this functionality floundered because it was a huge changeset and conflicts kept popping up with every passing day, so I thought it might be easier to divide into even smaller chunks. |
|
Aaaand #24304 has now materialised with all the labels for the top toolbar 😄 |
5916692 to
8981e82
Compare
161c9aa to
4039867
Compare
draganescu
left a comment
There was a problem hiding this comment.
#24304 is approved now and this makes sense 👍
4039867 to
30239dc
Compare
Description
Addresses #10524 and #15311
Adds an option in the Options modal to show labels for the editor UI icons.
No labels have been added yet; this is just the option toggle for the post editor. Further PRs will address adding the actual labels in each area where they are needed: the top toolbar and the block toolbar.
This and the upcoming PRs for the labels will replace #15830 as that PR has too many conflicts to be salvageable.
How has this been tested?
Tested in browser.
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: