Update passing of initial props on android#23938
Merged
Conversation
Merged
3 tasks
|
Size Change: -1.02 MB (88%) 🏆 Total Size: 1.15 MB
ℹ️ View Unchanged
|
cameronvoell
requested changes
Jul 20, 2020
Member
cameronvoell
left a comment
There was a problem hiding this comment.
Changes are awesome. However, looks like we still need to update MainActivity.java in the Demo App to fix the Android Demo app and CI.
Contributor
Author
Right you are @cameronvoell ! 👍 I've updated this PR to fix the demo app in daefab8 and updated the submodule refs in the gb-mobile and WPAndroid PRs. |
cameronvoell
approved these changes
Jul 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see the related WPAndroid PR for information about this PR.
Checklist: