Prevent Codecov from using "approximate" PR base commits#2354
Closed
Prevent Codecov from using "approximate" PR base commits#2354
Conversation
Member
|
From the code snippet provided in their docs, it seems
https://docs.codecov.io/v4.3.6/docs/comparing-commits#section-resolution Would this have any negative impact on rebases since the base commit would change? |
Member
Author
|
Good catch on the default being I re-ran my test from #2296 with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per https://docs.codecov.io/v4.3.6/docs/comparing-commits#section-resolution, if Codecov does not find a coverage report for the "base commit" of a pull request (the commit the PR shares in common with
master), then it will attempt to find a similar commit and use it as the base.This causes incorrect coverage results, I suspect it is the reason the report in #2226 is wrong and partly related to the Codecov issues in #2296 as well.
Testing at #2296 seems to indicate that adding this setting has the intended effect, and https://docs.codecov.io/v4.3.6/docs/commit-status seems to indicate that this situation won't cause a build failure due to the default setting of
if_not_found: success.