Description

This PR tries to fix random CI failures while bundling JS on:

• React Native E2E Tests (iOS): example
• React Native E2E Tests (Android): example

with the error:

info Done copying assets
 
Assertion failed: (!uv__is_closing(handle)), function uv_close, file ../deps/uv/src/unix/core.c, line 118.
 
sh: line 1:  3127 Abort trap: 6           react-native bundle --reset-cache --platform=ios --dev=false --minify false --entry-file=index.js --bundle-output=./gutenberg/packages/react-native-editor/ios/build/gutenberg/Build/Products/Release-iphonesimulator/GutenbergDemo.app/main.jsbundle --assets-dest=./gutenberg/packages/react-native-editor/ios/build/gutenberg/Build/Products/Release-iphonesimulator/GutenbergDemo.app
 
npm ERR! code ELIFECYCLE
 
npm ERR! errno 134

• Installing watchman before bundling seems to fix the issue.
• Removed maxWorkers: 2 parameter from metro config as well to utilize all cores when bundling and speed up the process
• Removed DependencyGraph.js patch for metro that was introduced in Hack: patch Metro to not watch files when bundling wordpress-mobile/gutenberg-mobile#873 as a hack to patch metro to not watch files when bundling. Current 0.58.0 version of metro that we are using now automatically checks if it's running on CI via ci-info npm package and doesn't enable watch.
• Modified React Native E2E tests runners to run on pull_request instead of push to decrease number of builds in the queue
• Remove non-working npm run cache clean command. It should've been npm cache clean but that also throws an error with this message: As of npm@5, the npm cache self-heals from corruption issues and data extracted from the cache is guaranteed to be valid. If you want to make sure everything is consistent, use 'npm cache verify' instead. On the other hand, if you're debugging an issue with the installer, you can use 'npm install --cache /tmp/empty-cache' to use a temporary cache instead of nuking the actual one. If you're sure you want to delete the entire cache, rerun this command with --force.

How has this been tested?

On CI I was able to consistently reproduce the issue by running clean and bundle commands 25 times in a row using this script:

for i in $(seq 1 25); do npm run native clean && npm run native clean:runtime && npm run native test:e2e:bundle:ios zsh -i -c exit; done

1. With watchman installed: https://github.com/WordPress/gutenberg/runs/804394303. Passed ✅
2. Without watchman: https://github.com/WordPress/gutenberg/runs/806522353. Failed ❌
3. Again with watchman installed: https://github.com/WordPress/gutenberg/runs/806756546. Passed ✅
4. Again without watchman: https://github.com/WordPress/gutenberg/runs/807124034. Failed ❌

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.