Adds back removed props and behavior back to Query Controls#23419
Merged
draganescu merged 1 commit intomasterfrom Jul 2, 2020
Merged
Adds back removed props and behavior back to Query Controls#23419draganescu merged 1 commit intomasterfrom
draganescu merged 1 commit intomasterfrom
Conversation
gziolo
approved these changes
Jun 24, 2020
Member
gziolo
left a comment
There was a problem hiding this comment.
It looks like it resolves backward compatibility issues.
What about React Native related props that were passed in the past to CategorySelect?
|
Size Change: +259 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Jun 24, 2020
Member
|
Is this supposed to include all the thousands of lines in the diff? Looks like we might have had a merge issue when trying to update or create the PR? |
Contributor
Author
|
There has been some problem with this PR ... |
fixing backward compat for plugins that use this component. the new behavior exists only if the new props are passed in.
fb62239 to
b3c1da4
Compare
Member
|
What's the status of this PR? Can it be merged? |
Merged
6 tasks
6 tasks
This was referenced Aug 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is fixing backward compatibility for plugins that use this component. The new behavior exists only if the new props are passed in.
Fixes #23285
Description
In a PR that improved the Latest Posts block by adding support for filtering by multiple category the
QueryControlscomponent had a couple of public props removed and that caused issues with plugins which were implementing the component.How has this been tested?
Tested locally by using the component in both ways in the
LatestPostsblock.Types of changes
Added back removed code from the component so everything should behave as expected. To have the component provide the new multiple category selector, pass in the new props.