Delete node_modules when running gradle's clean task#23391
Conversation
|
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
|
👋 @hypest! Just wanted to call your attention to the fact that I pushed a small, unrelated update in 8a87e41 where I am now constructing a file object a single time outside of the loop instead of doing it repeatedly inside the loop. Doing this just for the sake of performance, it should not change any behavior. |
hypest
left a comment
There was a problem hiding this comment.
✅ 4. Verify that the libs/gutenberg-mobile/node_modules and libs/gutenberg-mobile/gutenberg/node_modules directories no longer exist
✅ 6. Verify that you can load the gutenberg editor when running the generated apk
✅ 7. Verify that the libs/gutenberg-mobile/node_modules and libs/gutenberg-mobile/gutenberg/node_modules directories do not exist (confirms that the clean task does not interfere with the order of the tasks needed to generate the js bundle for android).
|
Will merge this one with "preserve commits" mode. |
Description
Updating the
react-native-bridge's clean task to also delete thenode_modulesdirectory. This will help ensure that developers who are not familiar with js development have a good chance of recovering from a bad state using the gradle build.In addition:
resetExtractedRNToolstask to print during the execution phase instead of the configuration phase;gutenberg/, Android Studio was overriding my settings and using tabs instead of spaces inside thegutenberg-mobile/gutenbergdirectory.How has this been tested?
Cleaning
libs/gutenberg-mobile/node_modulesandlibs/gutenberg-mobile/gutenberg/node_modulesdirectories are NOT empty. A dummy file is fine.gradle.propertiesfile haswp.BUILD_GUTENBERG_FROM_SOURCEset to false (or is missing that variable entirely)../gradlew cleanlibs/gutenberg-mobile/node_modulesandlibs/gutenberg-mobile/gutenberg/node_modulesdirectories no longer exist./gradlew clean installWasabiDebuglibs/gutenberg-mobile/node_modulesandlibs/gutenberg-mobile/gutenberg/node_modulesdirectories do not exist (confirms that the clean task does not interfere with the order of the tasks needed to generate the js bundle for android)..editorconfig
Do the following for a (1) .gradle, (2) .java, (3) .kt, and (4) .XML file somewhere within
packages/react-native-*/.Checklist: