[RNMobile] Fix issues with gradients on Button Block and resetting themes#23075
Merged
chipsnyder merged 3 commits intomasterfrom Jun 15, 2020
Merged
[RNMobile] Fix issues with gradients on Button Block and resetting themes#23075chipsnyder merged 3 commits intomasterfrom
chipsnyder merged 3 commits intomasterfrom
Conversation
3 tasks
|
Size Change: +621 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
mkevins
reviewed
Jun 15, 2020
|
|
||
| this.subscriptionParentUpdateTheme = subscribeUpdateTheme( | ||
| ( theme ) => { | ||
| // Reset the colors and gradients in case one theme was set with custom items and then updated to a theme without custom elements. |
mkevins
approved these changes
Jun 15, 2020
Contributor
mkevins
left a comment
There was a problem hiding this comment.
Tested via steps described, and via steps here: wordpress-mobile/WordPress-Android#12041 (comment) on a Pixel 3a (w/ Android 10). Works as expected. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix issue where an older value for gradients was being used on button blocks.
How has this been tested?
1.) Select a theme with custom gradients or add gradients to a theme
2.) Create a post or page
3.) Add a button block(s) and set the custom gradient
Expect to see the custom gradient on the block
1.) Select a theme with custom gradients or add gradients to a theme
2.) Open a post with a block that uses that custom color or gradient (such as a cover or button block)
Expect to see the custom gradient on the block (This will cache the theme)
3) Leave the editor and activate a different theme without custom colors or gradients set
4) Reopen the editor
Expect to see the default gray where the custom setting was originally applied after the theme updates
Screenshots
Types of changes
Bug fix
Checklist: