Fix Drag and Drop in Safari by upgrading Reakit#22960
Merged
Conversation
|
Size Change: +803 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Jun 6, 2020
Member
gziolo
left a comment
There was a problem hiding this comment.
Code ✅
Someone else should also confirm that it tests well 😃
ZebulanStanphill
approved these changes
Jun 6, 2020
Member
ZebulanStanphill
left a comment
There was a problem hiding this comment.
Tested in Safari on 13.1 on macOS Catalina 10.15.4. Drag-and-drop and clicking buttons in the heading level toolbar both work.
Member
|
Thanks for the fix @diegohaz ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades
reakitand fixes #22730 so drag and drop works in Safari again.Changelog
1.0.4 (2020-06-06)
Bug Fixes
Tabbablepreventing drag events on mouse down on Safari (#670) (6830c5a)1.0.3 (2020-06-04)
Bug Fixes
Tabbableon Safari and Firefox on MacOS (#658) (aad12ce)Performance Improvements
Compositeperformance (#660) (f6656b6)Before
After
Also, the workaround on the Heading level control dropdown is no longer necessary (cc @ZebulanStanphill):
Details
How to test