Remove withBlockEditContext internal higher-order component#22942
Merged
youknowriad merged 1 commit intomasterfrom Jun 8, 2020
Merged
Remove withBlockEditContext internal higher-order component#22942youknowriad merged 1 commit intomasterfrom
youknowriad merged 1 commit intomasterfrom
Conversation
aduth
commented
Jun 5, 2020
|
|
||
| let { completers = EMPTY_ARRAY } = props; | ||
|
|
||
| completers = useMemo( () => { |
Member
Author
There was a problem hiding this comment.
Note: There's a bit more intensive refactoring here than just a direct port. I observed the prior logic was fairly unoptimized if editor.Autocomplete.completers, since it would create a new copy of the array on every render. It's also not necessary to consider the filtering on every render, if we're already managing this memoization.
aduth
commented
Jun 5, 2020
| } | ||
|
|
||
| export default compose( | ||
| withBlockEditContext( ( { clientId } ) => { |
Member
Author
There was a problem hiding this comment.
Another interesting observation with migrating from higher-order components to hooks: With higher-order components, it's fairly easy to overlook when something is totally unused!
Member
There was a problem hiding this comment.
Yes, I've often seen left over selectors :)
|
Size Change: -69 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Jun 5, 2020
Contributor
|
Noting here that we have used Mentioning it here because I've noticed it's considered internal (from the PR title) but is also being leveraged at least in one plugin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #22905
This pull request seeks to remove the
withBlockEditContextinternal helper of the@wordpress/block-editorpackage. The motivation here is (a) to flatten the common block React element hierarchy and (b) to favor hooks-based implementations over higher-order components.withBlockEditContextwas a useful and expressive helper at the time it was originally implemented, due to the cumbersome nature of using React Context<Consumer>elements. WithuseContext, it's much simpler now to get direct access to the context object properties relevant for this behavior.Testing Instructions:
Verify no regressions in the behavior of affected components. For example, block-based autocomplete and alignment toolbar.