Update the block directory state to store the installing status per block id.#22881
Merged
StevenDufresne merged 5 commits intomasterfrom Jun 8, 2020
Merged
Conversation
|
Size Change: +784 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
ryelle
reviewed
Jun 4, 2020
Contributor
ryelle
left a comment
There was a problem hiding this comment.
I just noticed this yesterday, thanks for fixing it. It's working out in testing 👍
Some comments, but they're pretty minor.
packages/block-directory/src/components/downloadable-block-header/index.js
Show resolved
Hide resolved
packages/block-directory/src/components/downloadable-block-list-item/index.js
Outdated
Show resolved
Hide resolved
Comment on lines
+58
to
+61
| if ( ! state.blockManagement.isInstalling[ blockId ] ) { | ||
| return false; | ||
| } | ||
| return state.blockManagement.isInstalling[ blockId ]; |
Contributor
There was a problem hiding this comment.
You could simplify this like…
Suggested change
| if ( ! state.blockManagement.isInstalling[ blockId ] ) { | |
| return false; | |
| } | |
| return state.blockManagement.isInstalling[ blockId ]; | |
| return !! state.blockManagement.isInstalling[ blockId ]; |
Contributor
Author
There was a problem hiding this comment.
Funny enough, I had it that way but switched it back since it diverges from the way its done in other selectors.
Additionally, I find it less 'readable' for people who don't understand JS quirks.
Contributor
There was a problem hiding this comment.
huh, I found this pattern in a few other selectors. I don't have any strong preference, so this is good 👍
Contributor
Author
|
Noting: This needs more tests before merging. |
ryelle
approved these changes
Jun 5, 2020
Contributor
ryelle
left a comment
There was a problem hiding this comment.
Looks good 👍
Were you still planning on adding more tests? I think this is good to merge either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When installing a block from the block directory the
isInstallingstate is shared across all the results. This means that if I install 1 block, all the buttons display the loading state.How has this been tested?
Screenshots
Types of changes
Checklist: