Image: Add rich image editing option to experiments page#22870
Merged
ellatrix merged 6 commits intoWordPress:masterfrom Jun 8, 2020
Merged
Image: Add rich image editing option to experiments page#22870ellatrix merged 6 commits intoWordPress:masterfrom
ellatrix merged 6 commits intoWordPress:masterfrom
Conversation
Contributor
|
Thanks Alex. I discovered a small issue with the image tools yesterday where selecting an image sets focus on the caption, and I needed to test some things where that issue wasn't present, so I merged this branch into my other branch, and it appears to correctly disable the image tools. So for what it's worth, to me it seems worth it to keep Image tools merged, but disabled behind the experimental box. It allows us to fix the issues while still making it possible for users to discover issues in an easier way than checking out a PR. |
6 tasks
ellatrix
approved these changes
Jun 8, 2020
Member
ellatrix
left a comment
There was a problem hiding this comment.
Thanks you! Let's aim to unmark it as experimental by the next Gutenberg release.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As per discussion in #21024 (comment), this moves rich image editing to be an option which needs to be enabled by the user.
How has this been tested?
Run without the setting enabled and see that image editing tools are not shown.
Go to Gutenberg > Experiments and check "Enable Inline Rich Image Editing" and see that the image editing tools are shown.
Screenshots
Types of changes
Checklist: