Conversation
|
Size Change: +23 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
mtias
reviewed
May 21, 2020
| const DEFAULT_CONTROL = 'center'; | ||
| const WIDE_CONTROLS = [ 'wide', 'full' ]; | ||
|
|
||
| const POPOVER_PROPS = { |
Member
There was a problem hiding this comment.
What's the point of having this as a constant?
Contributor
Author
There was a problem hiding this comment.
It's the only way I found to get this prop to take.
Contributor
There was a problem hiding this comment.
I think the advantage is that the object is not regenerated on each render. On expensive pure components, it could have an impact but maybe not everywhere.
Contributor
Author
There was a problem hiding this comment.
Happy to do which ever you agree on. Just haven't been able to get it to work without this method.
Contributor
Author
There was a problem hiding this comment.
It would be nice to unblock this PR, so we don't ship the current change in master if we can avoid it. CC: @youknowriad
Contributor
There was a problem hiding this comment.
@jasmussen this shouldn't be a blocker IMO. You can inline these if needed. Performance is probably not a concern here.
Member
This may cease to be the case (at least temporarily until a better solution is found) once #21056 is merged. EDIT: It has now ceased to be the case! |
youknowriad
approved these changes
Jun 8, 2020
Contributor
Author
|
Thank you Riad. I'll merge this and address any follow-up that needs to be addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes small oversight in #22351 (comment)
The block editor uses elevation sparingly. Popovers by default have a shadow and ligther border because they, and modal dialogs, are elevated. But popovers in the canvas are not, and scroll under the top toolbar with the block. For those cases, we have the "alternate" display which uses block toolbar material to indicate the popover is part of that.
This PR fixes the typo that made all of them block toolbars, and fixes a couple of other cases where the old menus were used: