Block Directory: Only support an array of assets when injecting assets.#22289
Merged
StevenDufresne merged 1 commit intomasterfrom May 12, 2020
Merged
Conversation
|
Size Change: -34 B (0%) Total Size: 827 kB
ℹ️ View Unchanged
|
ryelle
approved these changes
May 12, 2020
Contributor
ryelle
left a comment
There was a problem hiding this comment.
confirming that assets is always an array, this is good to clean up 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the initial PR was merged, there was an expectation that the api could return either an
Arrayor anobject.The api does not return an
object. This code path will not be triggered.How has this been tested?
Types of changes
Note: I left the
if( Array.isArray( assets ) )check. It's probably best to make that check in case the api returns undefined.Checklist: