Block Editor: Include reusable blocks in announced inserter search results#22279
Merged
Block Editor: Include reusable blocks in announced inserter search results#22279
Conversation
This was referenced May 11, 2020
Merged
|
Size Change: +2.53 kB (0%) Total Size: 827 kB
ℹ️ View Unchanged
|
aduth
commented
May 11, 2020
Member
Author
|
Adding label "Needs Accessibility Feedback" in regards to my comment at #22279 (comment). |
2 tasks
youknowriad
approved these changes
May 12, 2020
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
The code change looks good. Would be good to have a confirmation about the deps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: https://github.com/WordPress/gutenberg/pull/10755/files#r423267328
This pull request seeks to resolve an issue where searching for a block in the block inserter would not count reusable blocks in the spoken message of search results. It also serves as a minor refactoring to simplify the logic involved in determining this count, using the direct result of
filteredItemsarray instead of recomputing an aggregate sum ofitemsPerCategory(which notably omits reusable blocks).Testing Instructions:
Verify block inserter search results announcement accounts for reusable block search results.
Ensure unit tests pass: