Skip to content

Add gap between nested submenus#22227

Merged
adamziel merged 1 commit into
masterfrom
update/sub-menus-gap
May 11, 2020
Merged

Add gap between nested submenus#22227
adamziel merged 1 commit into
masterfrom
update/sub-menus-gap

Conversation

@adamziel

@adamziel adamziel commented May 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adds a gap between nested submenus (See #22107)

Screenshots

Before
Zrzut ekranu 2020-05-8 o 16 22 20

After
Zrzut ekranu 2020-05-8 o 16 21 17

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@adamziel adamziel added [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Block] Navigation Affects the Navigation Block labels May 8, 2020
@adamziel adamziel requested review from karmatosed and talldan May 8, 2020 14:23
@adamziel adamziel self-assigned this May 8, 2020
@github-actions

github-actions Bot commented May 8, 2020

Copy link
Copy Markdown

Size Change: +59 B (0%)

Total Size: 824 kB

Filename Size Change
build/block-library/style-rtl.css 7.37 kB +29 B (0%)
build/block-library/style.css 7.37 kB +30 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.02 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 4.08 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.61 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 761 B 0 B
build/block-editor/index.js 102 kB 0 B
build/block-editor/style-rtl.css 10.3 kB 0 B
build/block-editor/style.css 10.3 kB 0 B
build/block-library/editor-rtl.css 7.12 kB 0 B
build/block-library/editor.css 7.12 kB 0 B
build/block-library/index.js 115 kB 0 B
build/block-library/theme-rtl.css 683 B 0 B
build/block-library/theme.css 685 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 180 kB 0 B
build/components/style-rtl.css 17 kB 0 B
build/components/style.css 16.9 kB 0 B
build/compose/index.js 6.66 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.45 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.1 kB 0 B
build/edit-navigation/index.js 4.4 kB 0 B
build/edit-navigation/style-rtl.css 618 B 0 B
build/edit-navigation/style.css 617 B 0 B
build/edit-post/index.js 28 kB 0 B
build/edit-post/style-rtl.css 12.2 kB 0 B
build/edit-post/style.css 12.2 kB 0 B
build/edit-site/index.js 12.1 kB 0 B
build/edit-site/style-rtl.css 5.22 kB 0 B
build/edit-site/style.css 5.22 kB 0 B
build/edit-widgets/index.js 8.37 kB 0 B
build/edit-widgets/style-rtl.css 4.69 kB 0 B
build/edit-widgets/style.css 4.69 kB 0 B
build/editor/editor-styles-rtl.css 425 B 0 B
build/editor/editor-styles.css 428 B 0 B
build/editor/index.js 44.3 kB 0 B
build/editor/style-rtl.css 5.07 kB 0 B
build/editor/style.css 5.08 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 734 B 0 B
build/format-library/index.js 7.63 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.14 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14.8 kB 0 B
build/server-side-render/index.js 2.67 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.02 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@adamziel adamziel mentioned this pull request May 8, 2020
Merged
6 tasks
@ZebulanStanphill

ZebulanStanphill commented May 8, 2020

Copy link
Copy Markdown
Member

Isn't this getting a bit too opinionated? This seems like something that belongs in a theme.scss file.

tellthemachines
tellthemachines approved these changes May 11, 2020
View reviewed changes

@tellthemachines tellthemachines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well!

karmatosed
karmatosed approved these changes May 11, 2020
View reviewed changes

@karmatosed karmatosed left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one thing to consider though is the background should reflect that of the theme for top level, sub-nav is ok being different. I know there is another issue for this, so just noting.

@adamziel

adamziel commented May 11, 2020

Copy link
Copy Markdown
Contributor Author

@ZebulanStanphill I think theme.scss is frontend-only, is that correct? In which case we'd need to add it both to theme.scss and editor.scss - which is equivalent of updating style.scss. I think it's okay to make the default a tiny bit opinionated, it should still be easy to override.

@adamziel

adamziel commented May 11, 2020

Copy link
Copy Markdown
Contributor Author

I'm going to go ahead and merge this one, it doesn't mean it's definitive of course - let's keep the conversation open either here or in #22087

@adamziel adamziel merged commit e1232fd into master May 11, 2020
@adamziel adamziel deleted the update/sub-menus-gap branch May 11, 2020 11:21
@github-actions github-actions Bot added this to the Gutenberg 8.1 milestone May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karmatosed karmatosed karmatosed approved these changes
@tellthemachines tellthemachines tellthemachines approved these changes
@talldan talldan Awaiting requested review from talldan
@ajitbohra ajitbohra Awaiting requested review from ajitbohra
@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta
@Soean Soean Awaiting requested review from Soean

Assignees

@adamziel adamziel

Labels

[Block] Navigation Affects the Navigation Block [Feature] List View Menu item in the top toolbar to select blocks from a list of links.

Projects

None yet

Milestone

Gutenberg 8.1

Development

Successfully merging this pull request may close these issues.

4 participants

@adamziel @ZebulanStanphill @karmatosed @tellthemachines